android_kernel_xiaomi_sm7250/fs/afs
David Howells 65c24caf1b afs: Fix dynamic root getattr
[ Upstream commit cb78d1b5efffe4cf97e16766329dd7358aed3deb ]

The recent patch to make afs_getattr consult the server didn't account
for the pseudo-inodes employed by the dynamic root-type afs superblock
not having a volume or a server to access, and thus an oops occurs if
such a directory is stat'd.

Fix this by checking to see if the vnode->volume pointer actually points
anywhere before following it in afs_getattr().

This can be tested by stat'ing a directory in /afs.  It may be
sufficient just to do "ls /afs" and the oops looks something like:

        BUG: kernel NULL pointer dereference, address: 0000000000000020
        ...
        RIP: 0010:afs_getattr+0x8b/0x14b
        ...
        Call Trace:
         <TASK>
         vfs_statx+0x79/0xf5
         vfs_fstatat+0x49/0x62

Fixes: 2aeb8c86d499 ("afs: Fix afs_getattr() to refetch file status if callback break occurred")
Reported-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
Tested-by: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://lore.kernel.org/r/165408450783.1031787.7941404776393751186.stgit@warthog.procyon.org.uk/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-07-02 16:27:33 +02:00
..
addr_list.c
afs_cm.h
afs_fs.h
afs_vl.h
afs.h
cache.c
callback.c
cell.c
cmservice.c
dir_edit.c
dir.c afs: Fix infinite loop found by xfstest generic/676 2022-06-14 16:59:34 +02:00
dynroot.c afs: Fix NULL deref in afs_dynroot_depopulate() 2020-08-26 10:31:05 +02:00
file.c
flock.c
fsclient.c
inode.c afs: Fix dynamic root getattr 2022-07-02 16:27:33 +02:00
internal.h
Kconfig
main.c afs: Fix an IS_ERR() vs NULL check 2021-06-30 08:48:14 -04:00
Makefile
misc.c
mntpt.c
netdevices.c
proc.c
rotate.c
rxrpc.c
security.c
server_list.c
server.c
super.c
vlclient.c
volume.c
write.c afs: afs_write_end() should change i_size under the right lock 2020-06-25 15:33:06 +02:00
xattr.c
xdr_fs.h