Jin Yao 31c5c44707 perf parse-events: Use strcmp() to compare the PMU name ... [ Upstream commit 8510895bafdbf7c4dd24c22946d925691135c2b2 ] A big uncore event group is split into multiple small groups which only include the uncore events from the same PMU. This has been supported in the commit 3cdc5c2cb9 ("perf parse-events: Handle uncore event aliases in small groups properly"). If the event's PMU name starts to repeat, it must be a new event. That can be used to distinguish the leader from other members. But now it only compares the pointer of pmu_name (leader->pmu_name == evsel->pmu_name). If we use "perf stat -M LLC_MISSES.PCIE_WRITE -a" on cascadelakex, the event list is: evsel->name evsel->pmu_name --------------------------------------------------------------- unc_iio_data_req_of_cpu.mem_write.part0 uncore_iio_4 (as leader) unc_iio_data_req_of_cpu.mem_write.part0 uncore_iio_2 unc_iio_data_req_of_cpu.mem_write.part0 uncore_iio_0 unc_iio_data_req_of_cpu.mem_write.part0 uncore_iio_5 unc_iio_data_req_of_cpu.mem_write.part0 uncore_iio_3 unc_iio_data_req_of_cpu.mem_write.part0 uncore_iio_1 unc_iio_data_req_of_cpu.mem_write.part1 uncore_iio_4 ...... For the event "unc_iio_data_req_of_cpu.mem_write.part1" with "uncore_iio_4", it should be the event from PMU "uncore_iio_4". It's not a new leader for this PMU. But if we use "(leader->pmu_name == evsel->pmu_name)", the check would be failed and the event is stored to leaders[] as a new PMU leader. So this patch uses strcmp to compare the PMU name between events. Fixes: d4953f7ef1a2 ("perf parse-events: Fix 3 use after frees found with clang ASAN") Signed-off-by: Jin Yao <yao.jin@linux.intel.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Jin Yao <yao.jin@intel.com> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lore.kernel.org/lkml/20200430003618.17002-1-yao.jin@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-10-01 13:14:49 +02:00
..
arch
bench	perf bench mem: Always memset source before memcpy	2020-08-21 11:05:38 +02:00
Documentation	perf record/stat: Explicitly call out event modifiers in the documentation	2020-09-09 19:04:22 +02:00
examples/bpf
include/bpf
jvmti
pmu-events	perf jevents: Fix leak of mapfile memory	2020-10-01 13:14:36 +02:00
python
scripts
tests	perf test: Fix test trace+probe_vfs_getname.sh on s390	2020-10-01 13:14:34 +02:00
trace	perf trace: Fix the selection for architectures to generate the errno name tables	2020-10-01 13:14:46 +02:00
ui	perf hists browser: Restore ESC as "Zoom out" of DSO/thread/etc	2020-03-05 16:42:22 +01:00
util	perf parse-events: Use strcmp() to compare the PMU name	2020-10-01 13:14:49 +02:00
.gitignore
Build
builtin-annotate.c
builtin-bench.c
builtin-buildid-cache.c
builtin-buildid-list.c
builtin-c2c.c
builtin-config.c
builtin-data.c
builtin-diff.c
builtin-evlist.c
builtin-ftrace.c
builtin-help.c
builtin-inject.c
builtin-kallsyms.c
builtin-kmem.c
builtin-kvm.c
builtin-list.c
builtin-lock.c
builtin-mem.c
builtin-probe.c	perf probe: Do not show the skipped events	2020-06-22 09:05:30 +02:00
builtin-record.c
builtin-report.c	perf report: Fix NULL pointer dereference in hists__fprintf_nr_sample_events()	2020-06-25 15:33:05 +02:00
builtin-sched.c
builtin-script.c
builtin-stat.c	perf stat: Fix duration_time value for higher intervals	2020-10-01 13:14:46 +02:00
builtin-timechart.c
builtin-top.c
builtin-trace.c
builtin-version.c
builtin.h
check-headers.sh
command-list.txt
CREDITS
design.txt
Makefile	tools: Let O= makes handle a relative path with -C option	2020-04-02 15:28:17 +02:00
Makefile.config	perf tools: Support Python 3.8+ in Makefile	2020-04-17 10:48:52 +02:00
Makefile.perf
MANIFEST
perf-archive.sh
perf-completion.sh
perf-read-vdso.c
perf-sys.h
perf-with-kcore.sh
perf.c
perf.h