267b3c6b3f
[ Upstream commit 208d3423ee463ab257908456f6bbca4024ab63f7 ]
gcc points out that when CONFIG_GPIOLIB is disabled,
gpiod_get_array_value_cansleep() returns 0 but fails to set its output:
drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status':
drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized]
This could be fixed more generally in gpiolib by returning a failure
code, but for this specific case, the easier workaround is to add a
gpiolib dependency.
Fixes: 5d1ebbda03 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
21 lines
549 B
Plaintext
21 lines
549 B
Plaintext
#
|
|
# Phy drivers for Motorola devices
|
|
#
|
|
config PHY_CPCAP_USB
|
|
tristate "CPCAP PMIC USB PHY driver"
|
|
depends on USB_SUPPORT && IIO
|
|
depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
|
|
select GENERIC_PHY
|
|
select USB_PHY
|
|
help
|
|
Enable this for USB to work on Motorola phones and tablets
|
|
such as Droid 4.
|
|
|
|
config PHY_MAPPHONE_MDM6600
|
|
tristate "Motorola Mapphone MDM6600 modem USB PHY driver"
|
|
depends on OF && USB_SUPPORT && GPIOLIB
|
|
select GENERIC_PHY
|
|
help
|
|
Enable this for MDM6600 USB modem to work on Motorola phones
|
|
and tablets such as Droid 4.
|