From 6b80031fa17000662b21a915e5b6bb4d4f7fbc3d Mon Sep 17 00:00:00 2001 From: Nick Desaulniers Date: Wed, 3 Feb 2021 10:47:48 -0800 Subject: [PATCH] Revert "Revert "ANDROID: enable LLVM_IAS=1 for clang's integrated assembler for x86_64"" This reverts commit e9a55d977044c6907c2d5317842345f7d543c34c. Re-enables the use of LLVM_IAS=1. This was disabled in aosp/1559459 due to a single time-based test failure. This test failure is not reproducible locally. The failure has never been observed on newer kernel versions either. We should consider disabling this test if we observe further flakes. Test: 1. apply this patch 2. build kernel image $ BUILD_CONFIG=common/build.config.gki.x86_64 build/build.sh && \ BUILD_CONFIG=common-modules/virtual-device/build.config.cuttlefish.x86_64 \ build/build.sh 3. launch cuttlefish with custom kernel image $ launch_cvd -kernel_path=/path/to/out/android-4.19-stable/dist/bzImage \ -initramfs_path=/path/to/out/android-4.19-stable/dist/initramfs.img & 4. run test $ atest vts_ltp_test_\ x86:syscalls.nanosleep01_32bit#syscalls.nanosleep01_32bit -- --abi x86 Test was repeated 10 times locally, 0 failures observed. Bug: 141693040 Bug: 178427746 Signed-off-by: Nick Desaulniers Change-Id: I6e93fafe0477df9c55cc6a0fa145660975927294 --- build.config.x86_64 | 1 + 1 file changed, 1 insertion(+) diff --git a/build.config.x86_64 b/build.config.x86_64 index b16ac8a68b25..cc3c66e7d3d5 100644 --- a/build.config.x86_64 +++ b/build.config.x86_64 @@ -1,5 +1,6 @@ ARCH=x86_64 +LLVM_IAS=1 CROSS_COMPILE=x86_64-linux-gnu- LINUX_GCC_CROSS_COMPILE_PREBUILTS_BIN=prebuilts/gas/linux-x86