R0dn3yS/android_kernel_xiaomi_sm7250
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "usb: gadget: mtp: Increase RX transfer length to 1M"

Browse Source 
This reverts commit 0db49c2550a09458db188fb7312c66783c5af104.

This results in kmalloc() abuse to find a large number of contiguous
pages, which thrashes the page allocator and hurts overall performance.
I couldn't reproduce the improved MTP throughput that this commit
claimed either, so just revert it.

Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
This commit is contained in:
Sultan Alsawaf 2020-02-20 08:53:54 -08:00 committed by spakkkk
parent 5dc0c03441
commit 0a2139efa8
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/gadget/function/f_mtp.c
View File

@ -56,7 +56,6 @@
ipc_log_string(_mtp_ipc_log, "%s: " fmt, __func__, ##__VA_ARGS__) ipc_log_string(_mtp_ipc_log, "%s: " fmt, __func__, ##__VA_ARGS__)
#endif #endif
#define MTP_RX_BUFFER_INIT_SIZE 1048576
#define MTP_BULK_BUFFER_SIZE 16384 #define MTP_BULK_BUFFER_SIZE 16384
#define INTR_BUFFER_SIZE 28 #define INTR_BUFFER_SIZE 28
#define MAX_INST_NAME_LEN 40 #define MAX_INST_NAME_LEN 40
@ -93,7 +92,7 @@
#define MAX_ITERATION 100 #define MAX_ITERATION 100
unsigned int mtp_rx_req_len = MTP_RX_BUFFER_INIT_SIZE; unsigned int mtp_rx_req_len = MTP_BULK_BUFFER_SIZE;
module_param(mtp_rx_req_len, uint, 0644); module_param(mtp_rx_req_len, uint, 0644);
unsigned int mtp_tx_req_len = MTP_BULK_BUFFER_SIZE; unsigned int mtp_tx_req_len = MTP_BULK_BUFFER_SIZE;